Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asdf plugin names in tests, and in specific, fix opentofu parsing in asdf parser #307

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

tspearconquest
Copy link
Contributor

@tspearconquest tspearconquest commented Dec 23, 2024

This PR should fix opentofu parsing in asdf parser. The asdf .tool-versions file uses the plugin name. For opentofu, the plugin is named "opentofu" rather than "tofu" so we must stick to the convention already in-use.

Additionally, it seemed silly to have asdf parsing tests for tenv to be checking asdf plugins which aren't related to the requested feature which brought about this code and the bug. So I've updated the tests and test data to use tenv tools only: atmos, opentofu and terragrunt. I thought of adding a test for terraform as well but felt it was probably beyond the scope of this bugfix.

@dvaumoron
Copy link
Contributor

thanks

@dvaumoron dvaumoron merged commit 2de0e1c into tofuutils:main Dec 23, 2024
4 checks passed
@tspearconquest
Copy link
Contributor Author

I made one minor mistake in the test data 1.8.6 instead of 1.8.7. Apologies, I am submitting that patch now.

@tspearconquest
Copy link
Contributor Author

Oh I see it was fixed when you merged. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants