Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_until_cancelled_owned to CancellationToken #7081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions tokio-util/src/sync/cancellation_token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,54 @@ impl CancellationToken {
}
.await
}

/// Runs a future to completion and returns its result wrapped inside of an `Option`
/// unless the `CancellationToken` is cancelled. In that case the function returns
/// `None` and the future gets dropped.
///
/// The function takes self by value.
///
/// # Cancel safety
///
/// This method is only cancel safe if `fut` is cancel safe.
pub async fn run_until_cancelled_owned<F>(self, fut: F) -> Option<F::Output>
where
F: Future,
{
pin_project! {
/// A Future that is resolved once the corresponding [`CancellationToken`]
/// is cancelled or a given Future gets resolved. It is biased towards the
/// Future completion.
#[must_use = "futures do nothing unless polled"]
struct RunUntilCancelledFuture<F: Future> {
#[pin]
cancellation: WaitForCancellationFutureOwned,
#[pin]
future: F,
}
}
Comment on lines +308 to +315
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more or less the same type defined in run_until_cancelled except for the type of the member future. I think it would make sense to merge both into a single type that is defined outside of the functions with a more generic parameter future so that we only have one definition of what is basically the same struct right now.


impl<F: Future> Future for RunUntilCancelledFuture<F> {
type Output = Option<F::Output>;

fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
let this = self.project();
if let Poll::Ready(res) = this.future.poll(cx) {
Poll::Ready(Some(res))
} else if this.cancellation.poll(cx).is_ready() {
Poll::Ready(None)
} else {
Poll::Pending
}
}
}

RunUntilCancelledFuture {
cancellation: self.cancelled_owned(),
future: fut,
}
.await
}
}

// ===== impl WaitForCancellationFuture =====
Expand Down
48 changes: 48 additions & 0 deletions tokio-util/tests/sync_cancellation_token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -493,3 +493,51 @@ fn run_until_cancelled_test() {
);
}
}

#[test]
fn run_until_cancelled_owned_test() {
let (waker, _) = new_count_waker();

{
let token = CancellationToken::new();
let to_cancel = token.clone();

let fut = token.run_until_cancelled_owned(std::future::pending::<()>());
pin!(fut);

assert_eq!(
Poll::Pending,
fut.as_mut().poll(&mut Context::from_waker(&waker))
);

to_cancel.cancel();

assert_eq!(
Poll::Ready(None),
fut.as_mut().poll(&mut Context::from_waker(&waker))
);
}

{
let (tx, rx) = oneshot::channel::<()>();

let token = CancellationToken::new();
let fut = token.run_until_cancelled_owned(async move {
rx.await.unwrap();
42
});
pin!(fut);

assert_eq!(
Poll::Pending,
fut.as_mut().poll(&mut Context::from_waker(&waker))
);

tx.send(()).unwrap();

assert_eq!(
Poll::Ready(Some(42)),
fut.as_mut().poll(&mut Context::from_waker(&waker))
);
}
}
Loading