2023-11-03: making the Response parsing consistent
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when deserializing the Response we're checking if `resp` and `resp.Response` are both != nil before trying to unmarshal. See hashicorp/terraform-provider-azurerm#25521 for an example of where this manifests by being done inconsistently - as such doing this across the board means this'll take effect everywhere, plus be included in any new operations which are based on the existing one
tombuildsstuff
force-pushed
the
b/making-response-parsing-consistent
branch
from
c1db60f to
57ad29f
Compare
tombuildsstuff
force-pushed
the
b/making-response-parsing-consistent
branch
from
57ad29f to
bbf0f64
Compare
|
Tests pass:
|
catriona-m
reviewed
Apr 5, 2024
| @@ -3,6 +3,8 @@ package files | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/hashicorp/go-azure-helpers/lang/pointer" | |||
There was a problem hiding this comment.
imports need sorted here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when deserializing the Response we're checking if
respandresp.Responseare both != nil before trying to unmarshal.See hashicorp/terraform-provider-azurerm#25521 for an example of where this manifests by being done inconsistently - as such doing this across the board means this'll take effect everywhere, plus be included in any new operations which are based on the existing one