Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: avoid clobbering response errors #118

Merged
merged 2 commits into from
Apr 22, 2024
Merged

bugfix: avoid clobbering response errors #118

merged 2 commits into from
Apr 22, 2024

Conversation

manicminer
Copy link
Collaborator

@manicminer manicminer commented Apr 19, 2024 •
edited
Loading

@manicminer manicminer added the bug Something isn't working label Apr 19, 2024
@manicminer manicminer force-pushed the bugfix/response-error-clobbering branch from 3b94bd8 to 16f1fbd Compare April 22, 2024 12:24
jackofallops
jackofallops approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - Aside from the bad code smell discussed offline, LGTM 👍

@manicminer manicminer merged commit 1f01155 into main Apr 22, 2024
1 check passed
@manicminer manicminer deleted the bugfix/response-error-clobbering branch April 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @jackofallops