fix: use parent shell path in place of node process path (#488)

* fix: use parent shell path and not node process path

* chore: add missing peer deps

* wip: add sh user paths from fish shell

* chore: undo extras

* refactor: ugly

src/shell/yvm.fish

@@ -76,6 +76,7 @@ function yvm
     end
 
     function yvm_call_node_script
+        set -lx sh_user_paths (string join ':' $PATH)
         set -lx fish_user_paths $fish_user_paths
         node "$YVM_DIR/yvm.js" $argv
     end

src/shell/yvm.sh

@@ -66,6 +66,7 @@ yvm() {
 
     yvm_call_node_script() {
         # do not add anything that outputs stuff to stdout in function, its output is stored in a variable
+        export sh_user_paths=$PATH
         node "${YVM_DIR}/yvm.js" $@
     }
 

src/util/path.js

@@ -27,7 +27,7 @@ export const getCurrentPath = shell => {
     if (isFishShell(shell)) {
         return process.env.fish_user_paths || ''
     }
-    return process.env.PATH || ''
+    return process.env.sh_user_paths || process.env.PATH || ''
 }
 
 export const yvmPath = process.env.YVM_DIR || path.resolve(os.homedir(), '.yvm')

test/util/path.test.js

@@ -19,7 +19,7 @@ describe('util.path', () => {
     const mockSystemPaths = ['/path/one', '/some/other/path', '/some/new/path']
     const mockPathEntries = [mockShimPath, mockVersionPath, ...mockSystemPaths]
 
-    jest.spyOnProp(process.env, 'PATH').mockValue(
+    jest.spyOnProp(process.env, 'sh_user_paths').mockValue(
         toPathString({
             paths: mockPathEntries,
         }),