This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Add dry-run option #129
Open
Neal910
wants to merge
5
commits into
toptal:master
Choose a base branch
from
Neal910:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add dry-run option #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@EPecherkin @jaimerson @pluff I don't have the capacity for CrystalBall right now, appreciate if you could take this over. |
any suggestions are appreciated. Thanks guys. |
jaimerson
reviewed
Sep 14, 2020
so far it's working with |
crystalball changes See merge request devops/rts-crystalball!1
Hey, folks! I am planning to work on a POC next week to implement selective running of RSPEC and Cucumber tests that are load balanced by Knapsack Pro. Any guidance on the status of this PR? Any reason it can't be merged into mainstream? Maybe something I can help with? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to tackle the issue of #117
Background:
I would like to output the prediction of a list of Rspec tests, so that the Knapsack Gem can accept the string and run the tests in parallel, as described here.
Personally, I came from Java world and am really new to the Ruby, actually this is my first Ruby project. Therefore, I am creating this prototype PR so that I can get more feedback in the beginning. Again, this PR is not meant to be merged but to discuss my proposal. All comments and suggestions are welcoming.