Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional parameter in pydantic_model_creator does not work f… #1599

Merged
merged 3 commits into from
May 7, 2024

Conversation

waketzheng
Copy link
Contributor

…or pydantic v2. (#1551)

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8907053547

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 87.935%

Totals Coverage Status
Change from base Build 8879569614: 0.001%
Covered Lines: 5772
Relevant Lines: 6468

💛 - Coveralls

@abondar abondar merged commit f36f8b7 into tortoise:develop May 7, 2024
7 checks passed
@waketzheng waketzheng deleted the fix-1551 branch May 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants