Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: susa 테스트 커버리지 보강 #299

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore: susa 테스트 커버리지 보강 #299

merged 2 commits into from
Nov 28, 2024

Conversation

po4tion
Copy link
Collaborator

@po4tion po4tion commented Nov 28, 2024

Overview

ASIS.
image

TOBE.
image

반환 타입을 정의하기 위해 불필요하게 선언되어 있던 에러문을 제거하여 테스트 커버리지를 보강합니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@po4tion po4tion self-assigned this Nov 28, 2024
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: deec6af

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 0:25am

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4599e57) to head (deec6af).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #299      +/-   ##
===========================================
+ Coverage   99.68%   100.00%   +0.31%     
===========================================
  Files          37        37              
  Lines         641       639       -2     
  Branches      155       154       -1     
===========================================
  Hits          639       639              
+ Misses          2         0       -2     

okinawaa
okinawaa previously approved these changes Nov 28, 2024
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@okinawaa okinawaa merged commit 44c840f into main Nov 28, 2024
2 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants