-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(package.json): lint by publint #93
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 86a9c0a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -38,6 +46,7 @@ | |||
"changeset:publish": "changeset publish", | |||
"changeset:version": "changeset version", | |||
"packlint": "packlint sort -R", | |||
"publint": "publint --strict", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 --strict 옵션이 어떤 역할을 해주나요?
publint가 문서가 잘 되어있지는 �않은것 같아서 strict 옵션에 대한 설명을 찾지 못했습니당 ㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strict옵션이 있으면 warning도 error로 체크할 수 있게 됩니다 그래서 더 엄격히 검사할 수 있는 장점이 있어요
https://github.com/bluwy/publint/blob/master/pkg/src/index.js#L381-L387
문서화가 잘 되어있지 않네요..! 이 부분 저 레포에 기여해보아야겠어요👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿입니다~!
Overview
publishConfig의 불필요한 필드를 제거합니다
publint를 통해 package.json lint를 합니다
publint는 https://publint.dev/ 패키지가 잘 퍼블리싱되고 있는지 린팅하는 툴입니다.
AS-IS
아래 publint에서 제공되는 링크로 [email protected]의 package.json의 제안사항을 확인할 수도 있습니다
https://publint.dev/[email protected]
TO-BE
yarn publint
)로도 확인할 수 있게 스크립트 필드에 추가했습니다. 이를 활용해 ci에서도 항상 체크됩니다.참고
PR Checklist