Merge pull request #103 from JakeWharton/patch-1

Remove superfluous value reads after write
touchlab · Mar 5, 2024 · 6f97449 · 6f97449
2 parents f930beb + 4197926
commit 6f97449
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/stately-concurrency/src/jsWasmMain/kotlin/co/touchlab/stately/concurrency/AtomicInt.kt b/stately-concurrency/src/jsWasmMain/kotlin/co/touchlab/stately/concurrency/AtomicInt.kt
@@ -23,8 +23,9 @@ actual class AtomicInt actual constructor(initialValue: Int) {
     private var internalValue: Int = initialValue
 
     actual fun addAndGet(delta: Int): Int {
-        internalValue += delta
-        return internalValue
+        return (internalValue + delta).also {
+            internalValue = it
+        }
     }
 
     actual fun compareAndSet(expected: Int, new: Int): Boolean {

diff --git a/stately-concurrency/src/jsWasmMain/kotlin/co/touchlab/stately/concurrency/AtomicLong.kt b/stately-concurrency/src/jsWasmMain/kotlin/co/touchlab/stately/concurrency/AtomicLong.kt
@@ -23,8 +23,9 @@ actual class AtomicLong actual constructor(initialValue: Long) {
     private var internalValue: Long = initialValue
 
     actual fun addAndGet(delta: Long): Long {
-        internalValue += delta
-        return internalValue
+        return (internalValue + delta).also {
+            internalValue = it
+        }
     }
 
     actual fun compareAndSet(expected: Long, new: Long): Boolean {