forked from kjk/the_silver_searcher
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
16 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Things that could be done for windows port: | ||
|
||
1. in options.c: | ||
gitconfig_file = popen("git config -z --get core.excludesfile", "r"); | ||
(and other uses of popen). | ||
|
||
If git is not installed, the following message ends up in stderr: | ||
|
||
"'git' is not recognized as an internal or external command, operable program or batch file." | ||
|
||
This is because popen() really does "cmd.exe /c git config ..." and executes | ||
it via CreateProcess() and, I'm guessing, cmd.exe is the one printing this | ||
message to stderr. | ||
|
||
I could re-implement popen() in a way that doesn't add "cmd.exe" |