Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bedrock): add response id attribute #2544

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

dinmukhamedm
Copy link
Contributor

Partially address #2236

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. python Pull requests that update Python code testing labels Jan 22, 2025
@dinmukhamedm
Copy link
Contributor Author

Oops, I will fix the linting issue, push again and ping you, sorry

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@nirga nirga merged commit 67873de into traceloop:main Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants