fix: fail gracefully

traefik · Nov 23, 2023 · 56c2b14 · 56c2b14
1 parent bad3af6
commit 56c2b14
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/traefik/templates/_podtemplate.tpl b/traefik/templates/_podtemplate.tpl
@@ -517,7 +517,13 @@
           {{- end }}
           {{- end }}
           {{- end }}
+          {{- if ne (typeOf .Values.experimental.plugins) "map[string]interface {}" }}
+            {{- fail (printf "ERROR: .Values.experimental.plugins should be a map (%s provided) !" (typeOf .Values.experimental.plugins)) }}
+          {{- end }}
           {{- range $pluginName, $plugin := .Values.experimental.plugins }}
+          {{- if or (ne (typeOf $plugin) "map[string]interface {}") (not (hasKey $plugin "moduleName")) (not (hasKey $plugin "version")) }}
+            {{- fail  (printf "ERROR: plugin %s is missing moduleName/version keys !" $pluginName) }}
+          {{- end }}
           - --experimental.plugins.{{ $pluginName }}.moduleName={{ $plugin.moduleName }}
           - --experimental.plugins.{{ $pluginName }}.version={{ $plugin.version }}
           {{- end }}

diff --git a/traefik/tests/traefik-config_test.yaml b/traefik/tests/traefik-config_test.yaml
@@ -193,6 +193,25 @@ tests:
           path: spec.template.spec.containers[0].args
           content: "--experimental.plugins.demo.version=v0.2.1"
 
+  - it: should fail gracefully when using old syntax
+    set:
+      experimental:
+        plugins:
+          enabled: true
+    asserts:
+      - failedTemplate:
+          errorMessage: "ERROR: plugin enabled is missing moduleName/version keys !"
+
+  - it: should fail gracefully on missing plugins information
+    set:
+      experimental:
+        plugins:
+          demo:
+            moduleName: github.com/traefik/plugindemo
+    asserts:
+      - failedTemplate:
+          errorMessage: "ERROR: plugin demo is missing moduleName/version keys !"
+
   - it: should have tls configuration args when specified in values.yaml for port
     set:
       ports: