Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Traefik Proxy)!: use namespaceOverride as expected #1290

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Dec 31, 2024

What does this PR do?

Use namespaceOverride in

  • publishedService of ingress
  • status address of gateway
  • antiaffinity example
  • certificate generation for Traefik Hub mutating webhook
  • name of ClusterRole
  • label selector (matchLabel of Deployment/StatefulSet)

⚠️ When using namespaceOverride, the label selector will be changed. It's an immutable field. It means it will delete and recreate the Deployment or the StatefulSet. It will delete all the pods before creating new ones.

=> When upgrading, it's recommended to deploy a new instance with the new version, switch the traffic to it and delete the previous one.

Motivation

Fixes #1289 (and similar issues)

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO 5 references to .Release.Namespace should be removed in traefik/templates/_helpers.tpl in the context of this PR.
It will:

  • fix hub admission webhook
  • fix cluster role name

@mloiseleur mloiseleur changed the title fix(Traefik Proxy): use namespaceOverride as expected fix(Traefik Proxy)!: use namespaceOverride as expected Jan 2, 2025
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c6a991d into traefik:master Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect value of publishedservice on ingress provider when overriding namespace
3 participants