chore(ci): 🔧 👷 add e2e test when releasing #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweaver87
approved these changes
Oct 19, 2023
| @@ -28,12 +28,42 @@ jobs: | |||
| - name: Test | |||
| run: make test | |||
|
|
|||
| - name: Track docs | |||
| - name: Test if it's a release PR | |||
There was a problem hiding this comment.
I would rather use an other workflow and filter on path. Instead, it forces you to use bash script tricks (set -e).
At least I would use conditional jobs instead of conditional steps.
| fi | ||
| set -e | ||
|
|
||
| - name: Check docs |
There was a problem hiding this comment.
I would use an auto-commit action.
2 tasks
darkweaver87
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Launch a kind cluster and test default install on Traefik for this Chart.
Supersede #941 on which I have a strange issue.
Motivation
Ensure it works before releasing. Fixes #654.
More
make testand all the tests passed