Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This PR updates some usages of the
jsonschema
crate including the recentmeta
API which is dedicated to meta-schema validation (and is substantially faster than creating a new validator viaValidator::new
). Also,validation_error_into_owned
is not needed anymore, asValidator::new
returnsValidationError<'static>
+ there is theValidationError::to_owned
method which does exactly whatvalidation_error_into_owned
was doing.Another small detail is that I've noticed that the actual validation error is ignored in
JsonColumnMetadata::validate
, so I replaced it withis_valid
which is usually significantly faster for invalid instances.