Package pkg renamed into internal. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piotrkowalczuk the PR description is not enough. Can you please elaborate? |
|
@pires done |
|
Sorry @piotrkowalczuk I've been quite busy with some issues regarding the development of some of the features and haven't been able to look at this properly. I agree with the argument but I'm not sure all the code moved in this PR should be moved or not, e.g. code related to the operator APIs, which may be imported by separate projects. After the dust is settled, and the team is satisfied with the delivery, I'll look back into this. |
|
@piotrkowalczuk can you please rebase? |
|
Want to give it a shot now @piotrkowalczuk? I'm trying not to import any code from Kubernetes codebase as I don't want to maintain any dependencies. |
|
Continued #8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code stored in
pkglooks like something that should be restricted only for internal use.internaldirectory inGOPATHput restrictions on a code that it contains. It is possible to import code frominternalpackage only in the sameGOPATHbranch.pkgpackage is dedicated for libraries that are also meant to be used by client/caller.More about this concept can be found here.