Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to specify delimiter for CSV inputs #44

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

aidanlabella
Copy link
Collaborator

@aidanlabella aidanlabella commented Apr 4, 2024

Describe your changes

Added support for other delimiters besides ',' in CSV files fed into EXAMM. This is especially useful when the input data has other delimiters such as tabs (which is really a TSV file) or semicolons.

What type is this change?

  • Bug fix
  • New feature

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • [] I have tested on MAC OS system
  • I have tested on Arch Linux system
  • I have tested on the RIT research cluster and updated the spack packages for compiling
  • My changes generate no new warnings
  • If the PR is related to a new feature, I added the running scripts for the new feature

How Has This Been Tested?

Evolved genomes on the UCI air quality dataset which uses semicolons as delimiters.

@aidanlabella aidanlabella requested a review from jkarns275 April 4, 2024 00:09
@jkarns275
Copy link
Collaborator

Code looks good about to test it on my computer + the cluster

@jkarns275
Copy link
Collaborator

also, install clang-format w/ brew and run the script scripts/util/format.sh to pass the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants