This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Enable DROP TABLE statement for Presto #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1825,7 +1831,7 @@ PRESTOGRES_DEST prestogres_send_to_where(Node *node) | |||
| * CREATE TABLE | |||
| * CREATE TABLE ... AS SELECT | |||
| */ | |||
| if (IsA(node, SelectStmt) || IsA(node, InsertStmt) || IsA(node, CreateStmt) || IsA(node, CreateTableAsStmt)) | |||
| if (IsA(node, SelectStmt) || IsA(node, InsertStmt) || IsA(node, CreateStmt) || IsA(node, CreateTableAsStmt) || IsA(node, DropStmt)) | |||
There was a problem hiding this comment.
@tomz Nice 👍
Setting NULL directly prestogres_system_catalog_relcache seems leaking memory. And I found prestogres_discard_system_catalog function which is called at https://github.com/tomz/prestogres/blob/master/src/protocol/pool_proto_modules.c#L1638-L1645
So probably the best place to discard system catalog is right after the if block as following:
if (IsA(node, CreateStmt))
{
CreateStmt *create_table_stmt = (CreateStmt *)node;
if (create_table_stmt->relation->relpersistence)
discard_temp_table_relcache();
/* prestogres: discard system catalog to recreate them next time at prestogres_init_system_catalog */
prestogres_discard_system_catalog();
}
+ else if (IsA(node, DropStmt))
+ {
+ /* prestogres: discard system catalog to recreate them next time at prestogres_init_system_catalog */
+ prestogres_discard_system_catalog();
+ }
…rary created pg_roles by Prestogres treasure-data#37'
Presto queries may result in outputs that contain multiple \0 or NULL characters. As a result, a single error message or notice may contain multiple \0 delimited strings which would get read at once on invocation to per_node_error_log(), which then attempts to 'unread' the contents it just read. However, the pool_unread invocation ends up unreading up to the first \0 character, and it does not unread the full message, causing subsequent calls to getting the postgres message kind to fail as the kind ends up being a \0 character.
This change allows JDBCv2 clients to work by allowing SET TRANSACTION statements such as SET SESSION CHARACTERISTIC as well as multistatement queries containing SET to route to psql rather than Presto.
Merge in SET passthrough to presto, remove code that improperly calls pool_unread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.