Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune Ruby versions in CI / Drop ruby 2.7, 3.0 and 3.1 supports #135

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Tune Ruby versions in CI / Drop ruby 2.7, 3.0 and 3.1 supports #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f3f1b2
Tune Ruby versions in CI
yuokada Jan 15, 2025
9c6ada6
Add ruby version to Gemfile
yuokada Jan 15, 2025
596790c
Update trino-client.gemspec to support ruby 3.4
yuokada Jan 15, 2025
22bc222
Update gemspec to require Ruby 3.2 or later
yuokada Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['2.7', '3.0', '3.2']
ruby-version: ['3.2', '3.3', '3.4']
faraday-version: ['~> 1', '~> 2']
env:
FARADAY_VERSION: ${{ matrix.faraday-version }}
Expand Down
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
source "https://rubygems.org/"
ruby "~> 3.2"
gemspec

group :development, :test do
gem "tiny-presto", "~> 0.0.10"
gem "faraday", ENV.fetch("FARADAY_VERSION", "~> 2")
gem "tiny-presto", "~> 0.0.10"
end
2 changes: 1 addition & 1 deletion trino-client-ruby/trino-client-ruby.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
gem.files = ["lib/trino-client-ruby.rb"]
gem.require_paths = ["lib"]

gem.required_ruby_version = ">= 2.7.0"
gem.required_ruby_version = ">= 3.2.0"

gem.add_dependency "trino-client", Trino::Client::VERSION
end
6 changes: 5 additions & 1 deletion trino-client.gemspec
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please updated gem.required_ruby_version = ">= 2.7.0" in this file too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Modified.

Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@ Gem::Specification.new do |gem|
gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
gem.require_paths = ["lib"]

gem.required_ruby_version = ">= 2.7.0"
gem.required_ruby_version = ">= 3.2.0"

gem.add_dependency "faraday", ">= 1", "< 3"
gem.add_dependency "faraday-gzip", ">= 1"
gem.add_dependency "faraday-follow_redirects", ">= 0.3"
gem.add_dependency "msgpack", [">= 1.5.1"]

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4")
gem.add_dependency("base64")
end

gem.add_development_dependency "rake", [">= 0.9.2", "< 14.0"]
gem.add_development_dependency "rspec", "~> 3.13.0"
gem.add_development_dependency "webmock", ["~> 3.0"]
Expand Down
Loading