Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecs avro updates #2666

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Codecs avro updates #2666

merged 10 commits into from
Oct 16, 2024

Conversation

darach
Copy link
Member

@darach darach commented Oct 16, 2024

Pull request

Description

Updates apache-avro and schema-registry-converters to latest so that tremor-codecs can be
used as a library in 3rd party projects. This expands type coverage to include nano resolution
timestamps in avro schemata. BigDecimal is not supported at this time due to limitations with
tremor's value model and data type system.

Checklist

  • [ x ] The RFC, if required, has been submitted and approved
  • [ x ] Any user-facing impact of the changes is reflected in docs.tremor.rs
  • [ x ] The code is tested
  • [ x ] Use of unsafe code is reasoned about in a comment
  • [ x ] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behaviour
  • [ x ] The performance impact of the change is measured (see below)

Performance

No or negligeable impact.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.22%. Comparing base (bff8093) to head (fad0d25).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
tremor-codec/src/codec/avro.rs 95.19% 5 Missing ⚠️
tremor-connectors/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files         309      309           
  Lines       60078    60161   +83     
=======================================
+ Hits        54805    54882   +77     
- Misses       5273     5279    +6     
Flag Coverage Δ
e2e-command 11.28% <0.00%> (-0.01%) ⬇️
e2e-integration 50.38% <0.00%> (-0.03%) ⬇️
e2e-unit 12.57% <0.00%> (-0.01%) ⬇️
e2etests 52.71% <0.00%> (-0.03%) ⬇️
tremorapi 14.50% <0.00%> (-0.01%) ⬇️
tremorcodec 63.11% <95.19%> (+0.44%) ⬆️
tremorcommon 63.04% <ø> (ø)
tremorconnectors 28.84% <0.00%> (-0.03%) ⬇️
tremorconnectorsaws 11.27% <0.00%> (-0.01%) ⬇️
tremorconnectorsazure 4.69% <0.00%> (-0.01%) ⬇️
tremorconnectorsgcp 25.29% <0.00%> (-0.03%) ⬇️
tremorconnectorsobjectstorage 0.06% <0.00%> (-0.01%) ⬇️
tremorconnectorsotel 12.57% <0.00%> (-0.02%) ⬇️
tremorconnectorstesthelpers 68.25% <ø> (ø)
tremorinflux 87.71% <ø> (ø)
tremorinterceptor 54.28% <ø> (ø)
tremorpipeline 31.14% <0.00%> (-0.04%) ⬇️
tremorruntime 47.22% <0.00%> (-0.03%) ⬇️
tremorscript 55.06% <0.00%> (-0.07%) ⬇️
tremorsystem 5.78% <0.00%> (-0.01%) ⬇️
tremorvalue 69.52% <ø> (-0.04%) ⬇️
unittests 89.08% <94.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tremor-connectors/src/impls/kafka.rs 91.07% <ø> (-0.04%) ⬇️
tremor-connectors/src/lib.rs 87.65% <0.00%> (ø)
tremor-codec/src/codec/avro.rs 92.36% <95.19%> (+0.24%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff8093...fad0d25. Read the comment docs.

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some tiny suggestions otherwisde 👍

tremor-codec/src/codec/avro.rs Outdated Show resolved Hide resolved
tremor-codec/src/codec/avro.rs Outdated Show resolved Hide resolved
tremor-codec/src/codec/avro.rs Outdated Show resolved Hide resolved
tremor-codec/src/codec/avro.rs Outdated Show resolved Hide resolved
darach and others added 6 commits October 16, 2024 16:02
Co-authored-by: Heinz N. Gies <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Co-authored-by: Heinz N. Gies <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Co-authored-by: Heinz N. Gies <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Co-authored-by: Heinz N. Gies <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Licenser
Licenser previously approved these changes Oct 16, 2024
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooh 🚀

@darach darach enabled auto-merge (rebase) October 16, 2024 14:24
@darach darach merged commit 228699a into tremor-rs:main Oct 16, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants