Skip to content

Commit

Permalink
refactor: Deprecate/delete bunch of {ggplot2} code
Browse files Browse the repository at this point in the history
Following copied-from-{ggplot2} functions are now deprecated:

* `remove_missing()`, instead use `ggplot2::remove_missing()`
* `flip_data()`, instead use `ggplot2::flip_data()`
* `flipped_names()`, instead use `ggplot2::flipped_names()`
* `gg_dep()`, instead use `ggplot2::gg_dep()`
* `has_flipped_aes()`, instead use `ggplot2::has_flipped_aes()`

Also deleted a bunch of unused copied-from-{ggplot2} code
  • Loading branch information
trevorld committed Jul 1, 2021
1 parent bb1cf30 commit 0a361b9
Show file tree
Hide file tree
Showing 16 changed files with 320 additions and 1,068 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
^pkgdown$
^data-raw$
^\.github$
^\.covrignore$
1 change: 1 addition & 0 deletions .covrignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
R/ggpattern-deprecated.R
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,5 @@ importFrom(grDevices,dev.off)
importFrom(grDevices,png)
importFrom(grDevices,rgb)
importFrom(stats,setNames)
importFrom(tibble,tibble)
importFrom(utils,head)
importFrom(utils,tail)
8 changes: 5 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ This means there are minor tweaks to visual behavior:
{ggpattern} / {gridpattern} builtin pattern and an error will
be thrown if you try to do so.

The following functions are no longer exported by {ggpattern}:


## Deprecated features

{ggpattern} now deprecates the following data/functions,
Expand All @@ -33,12 +30,17 @@ they may be removed in a future version of {ggpattern}:
* `create_gradient_img()`
* `fetch_placeholder_img()`
* `fill_area_with_img()`
* `flip_data()`, instead use `ggplot2::flip_data()`
* `flipped_names()`, instead use `ggplot2::flipped_names()`
* `gg_dep()`, instead use `ggplot2::gg_dep()`
* `has_flipped_aes()`, instead use `ggplot2::has_flipped_aes()`
* `magick_filter_names`, instead use `magick::filter_types()`
* `magick_gravity_names`, instead use `magick::gravity_types()`
* `magick_pattern_intensity_names`, instead use `gridpattern::names_magick_intensity`
* `magick_pattern_names`, instead use `gridpattern::names_magick`
* `magick_pattern_stripe_names`, instead use `gridpattern::names_magick_stripe`
* `placeholder_names`, instead use `gridpattern::names_placeholder`
* `remove_missing()`, instead use `ggplot2::remove_missing()`
* `should_stop()`, instead use `ggplot2::should_stop()`

## New features
Expand Down
Loading

0 comments on commit 0a361b9

Please sign in to comment.