Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor t3w1/ble related fixes #4502

Merged
merged 2 commits into from
Jan 23, 2025
Merged

minor t3w1/ble related fixes #4502

merged 2 commits into from
Jan 23, 2025

Conversation

TychoVrahe
Copy link
Contributor

This PR fixes few issues with T3W1 / BLE:

  • NRF driver didn't proprely disable one of the interrupts
  • wrong code alignment in trezorlib
  • adjustments to codec_v1 were made to accommodate the fact that our BLE implementation uses differently sized RX and TX packets

@TychoVrahe TychoVrahe self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/minor_fixes branch from 6c8202d to ba96b13 Compare January 14, 2025 21:11
@TychoVrahe TychoVrahe marked this pull request as ready for review January 15, 2025 08:01
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak January 15, 2025 08:01
cepetr
cepetr approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All embedded-related code looks good to me

matejcik
matejcik approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, you'll still need to run make gen to update the change in the mock files

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/minor_fixes branch from 739e7d4 to 86ae1df Compare January 23, 2025 14:36
@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/minor_fixes branch from 86ae1df to b6fe99e Compare January 23, 2025 14:42
@TychoVrahe TychoVrahe merged commit 69a61e9 into main Jan 23, 2025
94 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/T3W1/minor_fixes branch January 23, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

@matejcik matejcik matejcik approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TychoVrahe @matejcik @cepetr