-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add make changelog_style
for automatic changelog formatting
#4532
Conversation
|
Makefile
Outdated
./tools/generate-changelog.py --fix-style legacy/bootloader | ||
./tools/generate-changelog.py --fix-style legacy/firmware | ||
./tools/generate-changelog.py --fix-style legacy/intermediate_fw | ||
./tools/generate-changelog.py --fix-style python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is becoming rather fragile, instead embed this list into generate-changelog
and make it fail if someone tries to use a non-listed path, telling them to also add the thing they want to the known path list
(that way we have a single command for "changelog check" and "changelog style" and we enforce that every changelog used by someone will be added to that list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for the suggestion!
WDYT about 0132526?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I've also added @mmilata, since he is the author of tools/generate-changelog.py
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but also please update references to generate-changelog.py
in docs/misc/changelog.md
.
Thanks! |
Added also to `make style`. [no changelog]
dcb3b2a
to
c15837b
Compare
Squashed and rebased over |
Added also to
make style
.[no changelog]