Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootloader refactoring #4572

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bootloader refactoring #4572

wants to merge 4 commits into from

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Feb 4, 2025 •
edited
Loading

This PR implements major bootloader refactoring - as preparation for adding BLE.

  • overall structure should be close to how things are done in firmware/micropython
  • cleaner separation of communication layers
  • introducing workflows, separate of communication
  • workflows run from menu use same code as workflows triggered by communication
  • introducing unified polling mechanism
  • some error handling in communication is improved/introduced

@TychoVrahe TychoVrahe self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/reorg branch 5 times, most recently from bedf3bb to 97363e2 Compare February 6, 2025 15:14
@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/reorg branch from f37dfa0 to 8e4557e Compare February 7, 2025 20:51
@TychoVrahe TychoVrahe marked this pull request as ready for review February 9, 2025 20:56
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner February 9, 2025 20:56
@TychoVrahe TychoVrahe requested review from matejcik, hiviah and cepetr and removed request for prusnak February 9, 2025 20:56
hiviah
hiviah approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@hiviah hiviah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer without the hardcoded ui_result constants in workflow_bootloader, but they were there before he refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiviah hiviah hiviah approved these changes

@matejcik matejcik Awaiting requested review from matejcik

@cepetr cepetr Awaiting requested review from cepetr

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TychoVrahe @hiviah