Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add C source code for the pclmul crc32 variant #35

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

folkertdev
Copy link
Collaborator

so, now that I've done this, I'm not sure we really want this in the repo actually...

it really skews our code statistics on github, it doesn't really help anyone but me. it's a good idea to have the C source available somewhere but should it really live indefinitely in our repository?

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8c3a10a) 86.16% compared to head (8a2935a) 86.00%.

Files Patch % Lines
load-dynamic-libz-ng/src/lib.rs 31.81% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   86.16%   86.00%   -0.16%     
==========================================
  Files          31       31              
  Lines        6982     7003      +21     
==========================================
+ Hits         6016     6023       +7     
- Misses        966      980      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@folkertdev folkertdev marked this pull request as ready for review February 20, 2024 19:00
@folkertdev folkertdev merged commit 0f6a4bc into main Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant