Alert Notes WebView2 error fix

Fix System.IO.FileNotFoundException exception that occurs when editing alert notes if WebView2 is not installed. WebView2 is used for rendering the html generated from the markdown. There is an existing wrapper control used for job timeline that will prompt the user to install the runtime. #1183
trimble-oss · Jan 21, 2025 · 858af5d · 858af5d
1 parent 989c2a3
commit 858af5d
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 27 deletions.
diff --git a/DBADashGUI/AgentJobs/WebView2Wrapper.cs b/DBADashGUI/AgentJobs/WebView2Wrapper.cs
@@ -73,15 +73,15 @@ private void Setup_Completed(object sender, EventArgs e)
             SetupCompleted?.Invoke();
         }
 
-        public async Task NavigateToLargeString(string html)
+        public async Task<bool> NavigateToLargeString(string html)
         {
             try
             {
                 await EnsureCoreWebView2WrapperAsync();
             }
             catch (Exception)
             {
-                return;
+                return false;
             }
             try
             {
@@ -91,6 +91,8 @@ public async Task NavigateToLargeString(string html)
             {
                 LoadHTMLFromDisk(ex, html); // NavigateToString might fail if size exceeds 2MB.  Try loading from disk instead.
             }
+
+            return true;
         }
 
         // <summary>

diff --git a/DBADashGUI/SchemaCompare/CodeEditorForm.Designer.cs b/DBADashGUI/SchemaCompare/CodeEditorForm.Designer.cs
diff --git a/DBADashGUI/SchemaCompare/CodeEditorForm.cs b/DBADashGUI/SchemaCompare/CodeEditorForm.cs
@@ -40,14 +40,15 @@ public CodeEditor.CodeEditorModes Syntax
                 codeEditor1.Mode = value;
                 splitContainer1.Panel2Collapsed = value != CodeEditor.CodeEditorModes.Markdown;
                 tsMarkdownView.Visible = value == CodeEditor.CodeEditorModes.Markdown;
-                ShowMarkdownPreview();
+                _ = ShowMarkdownPreview();
             }
         }
 
-        private void ShowMarkdownPreview()
+        private async Task ShowMarkdownPreview()
         {
             if (codeEditor1.Mode != CodeEditor.CodeEditorModes.Markdown) return;
             if (!isWebViewInit) return;
+            lblError.Visible = false;
             try
             {
                 var pipeline = new MarkdownPipelineBuilder()
@@ -56,12 +57,16 @@ private void ShowMarkdownPreview()
                     .Build();
 
                 var html = Markdig.Markdown.ToHtml(codeEditor1.txtCode.Text, pipeline);
-                webView.NavigateToString(html);
-                ToggleMarkdown(EditEnabled, true);
+
+                var success = await webView2Wrapper.NavigateToLargeString(html);
+                ToggleMarkdown(EditEnabled | !success, true);
             }
             catch (Exception ex)
             {
-                webView.NavigateToString(ex.Message);
+                ToggleMarkdown(true, false);
+                lblError.Text = "Error loading markdown preview";
+                lblError.ToolTipText = ex.Message;
+                lblError.Visible = true;
             }
         }
 
@@ -90,9 +95,8 @@ public CodeEditorForm()
 
         private async void InitializeAsync()
         {
-            await webView.EnsureCoreWebView2Async(null);
             isWebViewInit = true;
-            ShowMarkdownPreview();
+            await ShowMarkdownPreview();
         }
 
         private void TsLineNumbers_Click(object sender, EventArgs e)