Sort queries on worker status web ui by descending reserved memory #24475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
force-pushed
the
webui-sort-queries-on-worker-by-memory
branch
from
c4e2854 to
4854766
Compare
takezoe
changed the title
takezoe
changed the title
takezoe
force-pushed
the
webui-sort-queries-on-worker-by-memory
branch
from
4854766 to
5e53e35
Compare
core/trino-web-ui/src/main/resources/webapp/src/components/WorkerStatus.jsx
Outdated
Show resolved
Hide resolved
core/trino-web-ui/src/main/resources/webapp/src/components/WorkerStatus.jsx
Outdated
Show resolved
Hide resolved
takezoe
force-pushed
the
webui-sort-queries-on-worker-by-memory
branch
from
5e53e35 to
68c4d3e
Compare
takezoe
force-pushed
the
webui-sort-queries-on-worker-by-memory
branch
from
68c4d3e to
650b00f
Compare
|
@raunaqmorarka Thank you for your review. I added screenshots and revised the code following your comments. |
raunaqmorarka
approved these changes
Jan 12, 2025
raunaqmorarka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are the list of queries on the worker status view.
It would be more useful if this list is sorted by memory to find memory consuming queries on the worker.
Before (Queries are listed randomly):
After (Queries are sorted by reserved memory):
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: