Add Parquet writer session properties docs #24748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Personally I think this is good. However we have duplicate docs in the Delta Lake connector. And parquet_writer_batch_size seems to be NOT supported by that connector .. so the implementation is a mess in the sense that it is NOT the same for all connectors.
Wdyt @electrum should be done here .. maybe we get rid of the docs in the Delta Lake connector and instead add it here. And check that the connectors implement all of them?
Thoughts @findinpath @raunaqmorarka ?
@devozerov stay tuned until we discussed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing references to several Parquet writer system properties.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.