Rename BigQuery test credentials key config #24752
Merged
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankvadariya
force-pushed
the
mayank/rename-bigquery-test-env-name
branch
from
8f4bcbc to
cef2a73
Compare
`bigquery.credentials-key` testing config name clashes with the actual config name and hence any new bigquery catalogs created through `CREATE CATALOG` command by running BigQueryQueryRunner may not pick the different key if provided in command.
mayankvadariya
force-pushed
the
mayank/rename-bigquery-test-env-name
branch
from
cef2a73 to
22f0064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigquery.credentials-keytesting config name clashes with the actual config name and hence any new bigquery catalogs created throughCREATE CATALOGcommand by running BigQueryQueryRunner may not pick the different key if provided in command.Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.