-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically configure spooling properties #24757
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
...trino-main/src/main/java/io/trino/server/protocol/spooling/SpoolingSessionProperties.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.server.protocol.spooling; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.inject.Inject; | ||
| import io.airlift.units.DataSize; | ||
| import io.trino.Session; | ||
| import io.trino.SystemSessionPropertiesProvider; | ||
| import io.trino.spi.TrinoException; | ||
| import io.trino.spi.session.PropertyMetadata; | ||
|
|
||
| import java.util.List; | ||
| import java.util.function.Consumer; | ||
|
|
||
| import static io.airlift.units.DataSize.Unit.KILOBYTE; | ||
| import static io.airlift.units.DataSize.Unit.MEGABYTE; | ||
| import static io.trino.plugin.base.session.PropertyMetadataUtil.dataSizeProperty; | ||
| import static io.trino.spi.StandardErrorCode.INVALID_SESSION_PROPERTY; | ||
| import static io.trino.spi.session.PropertyMetadata.booleanProperty; | ||
| import static io.trino.spi.session.PropertyMetadata.longProperty; | ||
|
|
||
| public class SpoolingSessionProperties | ||
| implements SystemSessionPropertiesProvider | ||
| { | ||
| // Spooled segments | ||
| public static final String INITIAL_SEGMENT_SIZE = "spooling_initial_segment_size"; | ||
| public static final String MAX_SEGMENT_SIZE = "spooling_max_segment_size"; | ||
|
|
||
| // Inlined segments | ||
| public static final String ALLOW_INLINING = "spooling_inlining_enabled"; | ||
| public static final String MAX_INLINED_SIZE = "spooling_max_inlined_size"; | ||
| public static final String MAX_INLINED_ROWS = "spooling_max_inlined_rows"; | ||
|
|
||
| private final List<PropertyMetadata<?>> sessionProperties; | ||
|
|
||
| @Inject | ||
| public SpoolingSessionProperties(SpoolingConfig spoolingConfig) | ||
| { | ||
| sessionProperties = ImmutableList.<PropertyMetadata<?>>builder() | ||
| .add(dataSizeProperty( | ||
| INITIAL_SEGMENT_SIZE, | ||
| "Initial size of a spooled segment", | ||
| spoolingConfig.getInitialSegmentSize(), | ||
| isDataSizeBetween(INITIAL_SEGMENT_SIZE, DataSize.of(1, KILOBYTE), DataSize.of(128, MEGABYTE)), | ||
| false)) | ||
| .add(dataSizeProperty( | ||
| MAX_SEGMENT_SIZE, | ||
| "Maximum size of a spooled segment", | ||
| spoolingConfig.getMaximumSegmentSize(), | ||
| isDataSizeBetween(MAX_SEGMENT_SIZE, DataSize.of(1, KILOBYTE), DataSize.of(128, MEGABYTE)), | ||
| false)) | ||
| .add(booleanProperty( | ||
| ALLOW_INLINING, | ||
| "Allow inlining initial rows", | ||
| spoolingConfig.isAllowInlining(), | ||
| false)) | ||
| .add(dataSizeProperty( | ||
| MAX_INLINED_SIZE, | ||
| "Maximum size of inlined data", | ||
| spoolingConfig.getMaximumInlinedSize(), | ||
| isDataSizeBetween(MAX_INLINED_SIZE, DataSize.of(1, KILOBYTE), DataSize.of(1, MEGABYTE)), | ||
| false)) | ||
| .add(longProperty( | ||
| MAX_INLINED_ROWS, | ||
| "Maximum number of rows that are allowed to be inlined per worker", | ||
| spoolingConfig.getMaximumInlinedRows(), | ||
| false)) | ||
| .build(); | ||
| } | ||
|
|
||
| private Consumer<DataSize> isDataSizeBetween(String property, DataSize min, DataSize max) | ||
| { | ||
| return value -> { | ||
| if (min.compareTo(value) > 0) { | ||
| throw new TrinoException(INVALID_SESSION_PROPERTY, "Session property '" + property + "' must be greater than " + min); | ||
| } | ||
|
|
||
| if (max.compareTo(value) < 0) { | ||
| throw new TrinoException(INVALID_SESSION_PROPERTY, "Session property '" + property + "' must be smaller than " + max); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| public static DataSize getInitialSegmentSize(Session session) | ||
| { | ||
| return session.getSystemProperty(INITIAL_SEGMENT_SIZE, DataSize.class); | ||
| } | ||
|
|
||
| public static DataSize getMaxSegmentSize(Session session) | ||
| { | ||
| return session.getSystemProperty(MAX_SEGMENT_SIZE, DataSize.class); | ||
| } | ||
|
|
||
| public static boolean isAllowInlining(Session session) | ||
| { | ||
| return session.getSystemProperty(ALLOW_INLINING, Boolean.class); | ||
| } | ||
|
|
||
| public static DataSize getMaxInlinedSize(Session session) | ||
| { | ||
| return session.getSystemProperty(MAX_INLINED_SIZE, DataSize.class); | ||
| } | ||
|
|
||
| public static long getMaxInlinedRows(Session session) | ||
| { | ||
| return session.getSystemProperty(MAX_INLINED_ROWS, Long.class); | ||
| } | ||
|
|
||
| @Override | ||
| public List<PropertyMetadata<?>> getSessionProperties() | ||
| { | ||
| return sessionProperties; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
spoolingConfignow an unused parameter? If so, let's drop it.