Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused argument #24766

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Remove unused argument #24766

merged 1 commit into from
Jan 22, 2025

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 22, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2025
@wendigo wendigo requested review from losipiuk and dekimir January 22, 2025 15:23
Copy link
Contributor

@dekimir dekimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing I don't understand is why CoordinatorSegmentResource still uses SpoolingConfig. Should it query the session instead?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 22, 2025

@dekimir no, retrievalMode that is used there is a static configuration option, it can't be changed with the session property

@wendigo wendigo merged commit b17fa4e into master Jan 22, 2025
101 of 104 checks passed
@wendigo wendigo deleted the serafin/cleanup branch January 22, 2025 16:40
@github-actions github-actions bot added this to the 469 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants