Allow to pass step length in Loki connector. #24862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested changes
Jan 31, 2025
| @@ -56,7 +56,7 @@ | |||
| <dependency> | |||
| <groupId>io.github.jeschkies</groupId> | |||
| <artifactId>loki-client</artifactId> | |||
| <version>0.0.2</version> | |||
| <version>0.0.3</version> | |||
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| import static java.util.Objects.requireNonNull; | |||
|
|
|||
| public record LokiTableHandle(String query, Instant start, Instant end, List<ColumnHandle> columnHandles) | |||
| public record LokiTableHandle(String query, Instant start, Instant end, Long step, List<ColumnHandle> columnHandles) | |||
Comment on lines
+98
to
+101
| Long step = (Long) ((ScalarArgument) arguments.get("STEP")).getValue(); | ||
| if (step == null) { | ||
| step = 0L; | ||
| } |
There was a problem hiding this comment.
What happens if we specify a negative value in step argument? Please add a test.
|
"Allow to pass step length in Loki connector." https://trino.io/development/process.html#pull-request-and-commit-guidelines-
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Loki API allows to pass the step length in seconds. This change updates the client and adds an optional
STEPparameter to the query range table function.This allows us to simplify the integration test as well.
Fixes #24861
Release notes