HBase Connection Registry usage with Phoenix JDBC url #24869
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run Edit: updated test to use new format for ZK ConnectionRegistry. RPC Registry for test is facing errors because in docker env, clients can exhaust master with RPC threadpool while it is already running in-house chores. |
virajjasani
force-pushed
the
reg
branch
5 times, most recently
from
2cfd35e to
9f24500
Compare
|
Looks good. +1 |
|
Thanks @lhofhansl! FYI @stoty if you would also like to take a look. |
|
LGTM. Note that in most cases the default jdbc:phoenix URL should be used, as the cluster can be determined from the hbase / hadoop config files that must be present on the classpath anyway for for correct operation. |
wendigo
reviewed
Feb 5, 2025
| @@ -79,7 +79,6 @@ private TestingPhoenixServer() | |||
| try { | |||
| MiniZooKeeperCluster zkCluster = this.hbaseTestingUtility.startMiniZKCluster(); | |||
| port = zkCluster.getClientPort(); | |||
|
|
|||
wendigo
reviewed
Feb 5, 2025
| (phoenix-connection-url)= | ||
| ### `phoenix.connection-url` | ||
|
|
||
| phoenix.connection-url supports multiple formats: |
wendigo
approved these changes
Feb 5, 2025
mosabua
requested changes
Feb 5, 2025
| (phoenix-connection-url)= | ||
| ### `phoenix.connection-url` | ||
|
|
||
| phoenix.connection-url supports multiple formats: |
There was a problem hiding this comment.
The connection URL for Phoenix set with phoenix.connection-url supports multiple formats:
| | `phoenix.config.resources` | No | Comma-separated list of configuration files (e.g. `hbase-site.xml`) to use for connection properties. These files must exist on the machines running Trino. | | ||
| | `phoenix.max-scans-per-split` | No | Maximum number of HBase scans that will be performed in a single split. Default is 20. Lower values will lead to more splits in Trino. Can also be set via session propery `max_scans_per_split`. For details see: [https://phoenix.apache.org/update_statistics.html](https://phoenix.apache.org/update_statistics.html). (This setting has no effect when guideposts are disabled in Phoenix.) | | ||
| | `phoenix.server-scan-page-timeout` | No | The time limit on the amount of work single RPC request can do before it times out. Type: [](prop-type-duration). | | ||
|
|
||
| (phoenix-connection-url)= | ||
| ### `phoenix.connection-url` |
There was a problem hiding this comment.
Connection URL:
Suggested change
| ### `phoenix.connection-url` | |
| ### Connection URL: |
| ### `phoenix.connection-url` | ||
|
|
||
| phoenix.connection-url supports multiple formats: | ||
| 1. `jdbc:phoenix[:zk_quorum][:zk_port][:zk_hbase_path][:principal][:keytab][;options]`. Connection uses HBase Zookeeper Registry. The `zk_quorum` is a comma separated list of ZooKeeper servers. The `zk_port` is the ZooKeeper port. The `zk_hbase_path` is the HBase root znode path, that is configurable using `hbase-site.xml`. By default the location is `/hbase`. Principal, Keytab and Options are optional. |
There was a problem hiding this comment.
Change this whole list into an item list and wrap at 80 char width so we can actually review wording.
Like
* `jdbc:phoenix[:zk_quorum][:zk_port][:zk_hbase_path][:principal][:keytab][;options]`:
Connection uses HBase Zookeeper Registry. The `zk_quorum` is a comma separated
list of ZooKeeper servers. The `zk_port` is the ZooKeeper port. The
`zk_hbase_path` is the HBase root znode path, that is configurable using
`hbase-site.xml`. By default the location is `/hbase`. Principal, Keytab and
Options are optional.
* `jdbc:phoenix+zk[:host1\:port1][,:host2\:port2]...[,:hostN\:portN][:zk_hbase_path][:principal][:keytab][;options]`:
Uses same Connection as above, however host:port pairs are separated by comma.
...
mosabua
reviewed
Feb 5, 2025
| @@ -47,11 +47,22 @@ The following Phoenix-specific configuration properties are available: | |||
|
|
|||
| | Property name | Required | Description | | |||
| |------------------------------------| -------- |--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | `phoenix.connection-url` | Yes | `jdbc:phoenix[:zk_quorum][:zk_port][:zk_hbase_path]`. The `zk_quorum` is a comma separated list of ZooKeeper servers. The `zk_port` is the ZooKeeper port. The `zk_hbase_path` is the HBase root znode path, that is configurable using `hbase-site.xml`. By default the location is `/hbase` | | |||
| | `phoenix.connection-url` | Yes | Detailed description: [](phoenix-connection-url). | | |||
There was a problem hiding this comment.
Suggested change
| | `phoenix.connection-url` | Yes | Detailed description: [](phoenix-connection-url). | | |
| | `phoenix.connection-url` | Yes | See [](phoenix-connection-url). | |
mosabua
reviewed
Feb 5, 2025
| @@ -47,11 +47,22 @@ The following Phoenix-specific configuration properties are available: | |||
|
|
|||
| | Property name | Required | Description | | |||
There was a problem hiding this comment.
Ideally we change this whole list into a list-table .. but that could be a separate commit before or after .. or even a separate PR
virajjasani
force-pushed
the
reg
branch
2 times, most recently
from
9024a1a to
d09425c
Compare
mosabua
requested changes
Feb 6, 2025
| Host names refers to HMaster server names, port refers to HMaster port. | ||
| Principal, Keytab and Options are optional. | ||
|
|
||
| PHOENIX-6523 introduced support for various Connection Registries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use various HBase Connection Registries with Phoenix JDBC url formats. Document with recommendations and use in test.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: