Fix (#2243)

Co-authored-by: Joshua Lampert <[email protected]> Co-authored-by: Hendrik Ranocha <[email protected]>
trixi-framework · Jan 22, 2025 · 1245b72 · 1245b72
1 parent 67a566c
commit 1245b72
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/src/solvers/dgsem/basis_lobatto_legendre.jl b/src/solvers/dgsem/basis_lobatto_legendre.jl
@@ -253,15 +253,13 @@ function SolutionAnalyzer(basis::LobattoLegendreBasis;
     nnodes_ = analysis_polydeg + 1
 
     nodes_, weights_ = gauss_lobatto_nodes_weights(nnodes_, RealT)
-    vandermonde_ = polynomial_interpolation_matrix(get_nodes(basis), nodes_)
+    vandermonde = polynomial_interpolation_matrix(get_nodes(basis), nodes_)
 
-    # type conversions to get the requested real type and enable possible
-    # optimizations of runtime performance and latency
+    # Type conversions to enable possible optimizations of runtime performance 
+    # and latency
     nodes = SVector{nnodes_, RealT}(nodes_)
     weights = SVector{nnodes_, RealT}(weights_)
 
-    vandermonde = Matrix{RealT}(vandermonde_)
-
     return LobattoLegendreAnalyzer{RealT, nnodes_, typeof(nodes), typeof(vandermonde)}(nodes,
                                                                                        weights,
                                                                                        vandermonde)

diff --git a/src/solvers/dgsem/l2projection.jl b/src/solvers/dgsem/l2projection.jl
@@ -122,11 +122,11 @@ function calc_reverse_upper(n_nodes, ::Val{:gauss_lobatto}, RealT = Float64)
     wbary = barycentric_weights(nodes)
 
     # Calculate projection matrix (actually: discrete L2 projection with errors)
-    operator = zeros(n_nodes, n_nodes)
+    operator = zeros(RealT, n_nodes, n_nodes)
     for j in 1:n_nodes
-        poly = lagrange_interpolating_polynomials(1 / 2 * (nodes[j] + 1), nodes, wbary)
+        poly = lagrange_interpolating_polynomials(0.5f0 * (nodes[j] + 1), nodes, wbary)
         for i in 1:n_nodes
-            operator[i, j] = 1 / 2 * poly[i] * weights[j] / weights[i]
+            operator[i, j] = 0.5f0 * poly[i] * weights[j] / weights[i]
         end
     end
 
@@ -141,11 +141,11 @@ function calc_reverse_lower(n_nodes, ::Val{:gauss_lobatto}, RealT = Float64)
     wbary = barycentric_weights(nodes)
 
     # Calculate projection matrix (actually: discrete L2 projection with errors)
-    operator = zeros(n_nodes, n_nodes)
+    operator = zeros(RealT, n_nodes, n_nodes)
     for j in 1:n_nodes
-        poly = lagrange_interpolating_polynomials(1 / 2 * (nodes[j] - 1), nodes, wbary)
+        poly = lagrange_interpolating_polynomials(0.5f0 * (nodes[j] - 1), nodes, wbary)
         for i in 1:n_nodes
-            operator[i, j] = 1 / 2 * poly[i] * weights[j] / weights[i]
+            operator[i, j] = 0.5f0 * poly[i] * weights[j] / weights[i]
         end
     end