Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Split Unstructured <-> DGMulti; Parabolic #2234

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DanielDoehring
Copy link
Contributor

The "unstructured_dgmulti" and "parabolic" tests run almost twice as long as the other tests (over an hour compared to more than 30 min.) This PR aims to reduce CI time by parallelizing these tests.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (fafa540) to head (23ef740).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2234   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         487      487           
  Lines       39352    39352           
=======================================
  Hits        37942    37942           
  Misses       1410     1410           
Flag Coverage Δ
unittests 96.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielDoehring DanielDoehring marked this pull request as ready for review January 14, 2025 19:10
@ranocha
Copy link
Member

ranocha commented Jan 15, 2025

It looks like we just gained 15 minutes or so:

  • unstructured - ubuntu-latest - x64 (pull_request) Successful in 34m
  • dgmulti - ubuntu-latest - x64 (pull_request) Successful in 50m
  • parabolic_part1 - ubuntu-latest - x64 (pull_request) Successful in 21m
  • parabolic_part2 - ubuntu-latest - x64 (pull_request) Successful in 38m
  • parabolic_part3 - ubuntu-latest - x64 (pull_request) Successful in 45m

from a bit more than an hour to 50 minutes for dgmulti and 45 minutes for parabolic stuff.

I'm fine trying to speed up CI. However, a lot of time is spent compiling stuff. What do we get when we merge the first two parabolic CI jobs?

@DanielDoehring
Copy link
Contributor Author

We could also group 1D & 3D for the DGMulti and split this from the 2D tests.

@DanielDoehring DanielDoehring marked this pull request as draft January 15, 2025 08:09
@ranocha
Copy link
Member

ranocha commented Jan 15, 2025

MPI on Ubuntu still takes 50 minutes, limiting the CI runtime. Would you like to split it or shall we group other jobs since 50 minutes is already fine?

Did you check whether all jobs started together or whether we need to wait for some jobs to finish before new CI resources become available?

@DanielDoehring
Copy link
Contributor Author

We could also split the MPI tests into 2D/3D or p4est/t8code, yes.

Right, in general there are some other CI jobs running and CI times of individual Jobs differ significantly from run to run.

@DanielDoehring
Copy link
Contributor Author

Xref: #2197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants