-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Split Unstructured <-> DGMulti; Parabolic #2234
base: main
Are you sure you want to change the base?
CI: Split Unstructured <-> DGMulti; Parabolic #2234
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 487 487
Lines 39352 39352
=======================================
Hits 37942 37942
Misses 1410 1410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks like we just gained 15 minutes or so:
from a bit more than an hour to 50 minutes for dgmulti and 45 minutes for parabolic stuff. I'm fine trying to speed up CI. However, a lot of time is spent compiling stuff. What do we get when we merge the first two parabolic CI jobs? |
We could also group 1D & 3D for the |
MPI on Ubuntu still takes 50 minutes, limiting the CI runtime. Would you like to split it or shall we group other jobs since 50 minutes is already fine? Did you check whether all jobs started together or whether we need to wait for some jobs to finish before new CI resources become available? |
We could also split the MPI tests into 2D/3D or p4est/t8code, yes. Right, in general there are some other CI jobs running and CI times of individual Jobs differ significantly from run to run. |
Xref: #2197 |
The "unstructured_dgmulti" and "parabolic" tests run almost twice as long as the other tests (over an hour compared to more than 30 min.) This PR aims to reduce CI time by parallelizing these tests.