-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compat for DiffEqBase.jl and DiffEqCallbacks.jl #2263
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Update test/test_dgmulti_2d.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ework/Trixi.jl into jc/wrap_VectorOfArray
…rap_VectorOfArray
This reverts commit 1b700bc.
…ework/Trixi.jl into jc/wrap_VectorOfArray
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ework/Trixi.jl into jc/wrap_VectorOfArray
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Lampert <[email protected]>
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
- Coverage 96.87% 96.44% -0.43%
==========================================
Files 490 490
Lines 39462 39462
==========================================
- Hits 38228 38057 -171
- Misses 1234 1405 +171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
The good news is that the new versions of the SciML stack are used (the latest versions of DiffEqBase.jl, SciMLBase.jl, OrdinaryDiffEq.jl, DiffEqCallbacks.jl) and everything precompiles successfully. The bad news is that we still have some work to do to fix some errors mostly related to SciML packages. |
Closing this in favor of #2264. |
Let's already have a look in this PR if CI passes, when we remove the compat bounds.
In conjunction with #2150:
Closes #1789, closes #1785, closes #1240, closes #2108, closes #2120, closes #2121, closes #2157, closes #1791, closes #1850, closes #2091.