Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cross from LinearAlgebra instead of Trixi.cross #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jan 20, 2025

This avoids possible issues if we change something in Trixi.jl.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (13611fc) to head (bf12c3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files          20       20           
  Lines        1802     1802           
=======================================
  Hits         1612     1612           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tristanmontoya tristanmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense; LGTM. The windows CI errors are unrelated, but haven't looked into the specific cause (they seem to be present in Trixi.jl as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants