Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some fields which don't have values such as GROUP, etc are shown as column. #39

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: some fields which don't have values such as GROUP, etc are shown as column. #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f4dc3d
fix: some fields which don't have values such as GROUP, etc show as c…
yas-okadatech Oct 31, 2023
98eccce
remoe dev2 from version number
yas-okadatech Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repositories {
}

group = "io.trocco"
version = "0.1.9"
version = "0.1.10.dev2"
yas-okadatech marked this conversation as resolved.
Show resolved Hide resolved

sourceCompatibility = 1.8
targetCompatibility = 1.8
Expand Down
8 changes: 6 additions & 2 deletions src/main/java/org/embulk/input/kintone/KintoneInputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ private Schema buildSchema(final PluginTask task)
builder.add("$revision", Types.LONG);

for (Map.Entry<String, FieldProperty> fieldEntry : fields.entrySet()) {
builder.add(fieldEntry.getKey(), buildType(fieldEntry.getValue().getType()));
final Type type = buildType(fieldEntry.getValue().getType());
if (type != null) {
builder.add(fieldEntry.getKey(), type);
}
}

return builder.build();
Expand Down Expand Up @@ -230,8 +233,9 @@ private Type buildType(final FieldType fieldType)
case STATUS_ASSIGNEE:
case TIME:
case USER_SELECT:
default:
return Types.STRING;
default:
return null;
}
}
}