-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct raw value access for calculated fields #44
Add direct raw value access for calculated fields #44
Conversation
result
before
after
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test with non-numeric data in CALC
type.
@@ -106,7 +106,7 @@ public Record createTestRecord() | |||
testRecord.putField("作成日時", new CreatedTimeFieldValue(ZonedDateTime.parse("2012-01-11T11:30:00Z"))); | |||
testRecord.putField("更新者", new ModifierFieldValue(modifier)); | |||
testRecord.putField("更新日時", new UpdatedTimeFieldValue(ZonedDateTime.parse("2012-01-11T11:30:00Z"))); | |||
testRecord.putField("計算", new CalcFieldValue(new BigDecimal("1.23E-12"))); | |||
testRecord.putField("計算", new CalcFieldValue("1.23E-12")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test case like
testRecord.putField("計算(time)", new CalcFieldValue("12:34:56"));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
issue
summary
before
The existing process involved converting to BigDecimal.
If a value in an unconvertible format was passed, it would result in an error.
after