Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct raw value access for calculated fields #44

Merged
merged 3 commits into from
May 10, 2024

Conversation

@pn-koshikawa pn-koshikawa self-assigned this Apr 30, 2024
@pn-koshikawa pn-koshikawa marked this pull request as draft April 30, 2024 05:58
@pn-koshikawa
Copy link
Contributor Author

pn-koshikawa commented May 1, 2024

result

before

+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+
| テスト6:boolean | テスト7:boolean | テスト6:string | テスト7:string |  テスト6:long |  テスト7:long | テスト6:double | テスト7:double |
+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+
|        false |        false |    31622400 |    31622400 | 31,622,400 | 31,622,400 |   3.16224E7 |   3.16224E7 |
+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+

after

+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+
| テスト6:boolean | テスト7:boolean | テスト6:string | テスト7:string |  テスト6:long |  テスト7:long | テスト6:double | テスト7:double |
+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+
|        false |        false |    31622400 |    31622400 | 31,622,400 | 31,622,400 |   3.16224E7 |   3.16224E7 |
+--------------+--------------+-------------+-------------+------------+------------+-------------+-------------+

@pn-koshikawa pn-koshikawa marked this pull request as ready for review May 1, 2024 05:43
@pn-koshikawa pn-koshikawa requested a review from Pasukaru1996 May 1, 2024 06:34
Copy link

@Pasukaru1996 Pasukaru1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦉

@Pasukaru1996 Pasukaru1996 requested a review from d-hrs May 9, 2024 08:31
Copy link
Contributor

@d-hrs d-hrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test with non-numeric data in CALC type.

@@ -106,7 +106,7 @@ public Record createTestRecord()
testRecord.putField("作成日時", new CreatedTimeFieldValue(ZonedDateTime.parse("2012-01-11T11:30:00Z")));
testRecord.putField("更新者", new ModifierFieldValue(modifier));
testRecord.putField("更新日時", new UpdatedTimeFieldValue(ZonedDateTime.parse("2012-01-11T11:30:00Z")));
testRecord.putField("計算", new CalcFieldValue(new BigDecimal("1.23E-12")));
testRecord.putField("計算", new CalcFieldValue("1.23E-12"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test case like

        testRecord.putField("計算(time)", new CalcFieldValue("12:34:56"));

@pn-koshikawa pn-koshikawa requested a review from d-hrs May 10, 2024 04:23
Copy link
Contributor

@d-hrs d-hrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pn-koshikawa pn-koshikawa merged commit 555d5f2 into master May 10, 2024
1 check passed
@pn-koshikawa pn-koshikawa deleted the feature/#23273_get_calc_field_raw_method branch May 10, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants