Coordinate string date behavior

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.4 - 2019-11-06
+
+* [enhancement] Add DATETIME type conveter (thanks to @kekekenta)
+
 ## 0.6.3 - 2019-10-28
 
 * [enhancement] Add DATE type conveter (thanks to @tksfjt1024)

embulk-output-bigquery.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "embulk-output-bigquery"
-  spec.version       = "0.6.3"
+  spec.version       = "0.6.4"
   spec.authors       = ["Satoshi Akama", "Naotoshi Seo"]
   spec.summary       = "Google BigQuery output plugin for Embulk"
   spec.description   = "Embulk plugin that insert records to Google BigQuery."

lib/embulk/output/bigquery/value_converter_factory.rb

@@ -204,12 +204,19 @@ def string_converter
               }
             end
           when 'DATE'
-            Proc.new {|val|
-              next nil if val.nil?
-              with_typecast_error(val) do |val|
-                TimeWithZone.set_zone_offset(Time.parse(val), zone_offset).strftime("%Y-%m-%d")
-              end
-            }
+            if @timestamp_format
+              Proc.new {|val|
+                next nil if val.nil?
+                with_typecast_error(val) do |val|
+                  TimeWithZone.set_zone_offset(Time.parse(val), zone_offset).strftime("%Y-%m-%d")
+                end
+              }
+            else
+              Proc.new {|val|
+                next nil if val.nil?
+                val # Users must care of BQ timestamp format
+              }
+            end
           when 'DATETIME'
             if @timestamp_format
               Proc.new {|val|

test/test_value_converter_factory.rb

@@ -241,11 +241,17 @@ def test_timestamp
         end
 
         def test_date
+          converter = ValueConverterFactory.new(
+              SCHEMA_TYPE, 'DATE',
+              timestamp_format: '%Y/%m/%d'
+          ).create_converter
+          assert_equal nil, converter.call(nil)
+          assert_equal "2016-02-26", converter.call("2016/02/26")
+
+          # Users must care of BQ date format by themselves with no timestamp_format
           converter = ValueConverterFactory.new(SCHEMA_TYPE, 'DATE').create_converter
           assert_equal nil, converter.call(nil)
           assert_equal "2016-02-26", converter.call("2016-02-26")
-          assert_equal "2016-02-26", converter.call("2016-02-26 00:00:00")
-          assert_raise { converter.call('foo') }
         end
 
         def test_datetime