Fix imports #14
Merged
Fix imports #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires the developer to once execute
git config --local core.hooksPath .githooks/
Closed
mscho527
requested changes
Nov 21, 2024
| import sys | ||
| from functools import reduce | ||
|
|
||
| import numpy | ||
|
|
||
| import scipy.linalg | ||
| from libdmet.lo import pywannier90 |
There was a problem hiding this comment.
pywannier90 is optional; would moving this to the top affect environments that don't have wannier90 configured?
There was a problem hiding this comment.
as discussed with @mscho527 in person, the pywannier python interface is always there. It just might not work, if the wannier library is not installed.
mscho527
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review after #13 is merged