Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more checks #17

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Add more checks #17

merged 8 commits into from
Nov 22, 2024

Conversation

mcocdawc
Copy link
Contributor

@mcocdawc mcocdawc commented Nov 21, 2024 •
edited
Loading

  • added support for mypy in the CI pipeline

  • added support for pylint in the CI pipeline; this is necessary because ruff cannot detect unresolved imports (yet)

@mcocdawc mcocdawc requested a review from mscho527 November 21, 2024 19:44
@mcocdawc mcocdawc changed the title WIP: Add more checks Add more checks Nov 21, 2024
@mcocdawc mcocdawc requested review from lweisburn and mscho527 and removed request for mscho527 and lweisburn November 21, 2024 20:02
mscho527
mscho527 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mscho527 mscho527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool nice cool

@mcocdawc mcocdawc merged commit 893bec0 into main Nov 22, 2024
4 checks passed
@mscho527 mscho527 deleted the add_more_checks branch December 3, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscho527 mscho527 mscho527 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcocdawc @mscho527