Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed boolean expressions + bare excepts #18

Merged
merged 5 commits into from
Nov 22, 2024
Merged

fixed boolean expressions + bare excepts #18

merged 5 commits into from
Nov 22, 2024

Conversation

mcocdawc
Copy link
Contributor

@mcocdawc mcocdawc commented Nov 21, 2024 •
edited
Loading

  • Fixed a couple of boolean expressions to not compare with True/False, i.e. use
if not A:
# instead of
if A == False:
  • Fixed some bare excepts

@mcocdawc mcocdawc requested a review from mscho527 November 21, 2024 19:52
@mcocdawc mcocdawc force-pushed the boolean_expr_and_bare_except branch 2 times, most recently from 2f12ff6 to bdde763 Compare November 21, 2024 20:06
@mcocdawc mcocdawc changed the title WIP: fixed boolean expressions + bare excepts fixed boolean expressions + bare excepts Nov 21, 2024
@mcocdawc mcocdawc changed the title fixed boolean expressions + bare excepts WIP: fixed boolean expressions + bare excepts Nov 21, 2024
@mcocdawc mcocdawc force-pushed the boolean_expr_and_bare_except branch from 5307ba1 to 57f6b4f Compare November 22, 2024 15:19
@mcocdawc mcocdawc changed the title WIP: fixed boolean expressions + bare excepts fixed boolean expressions + bare excepts Nov 22, 2024
@mcocdawc mcocdawc requested a review from lweisburn November 22, 2024 16:27
mscho527
mscho527 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mscho527 mscho527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cool cool nice nice

@mcocdawc mcocdawc merged commit eb86ef0 into main Nov 22, 2024
4 checks passed
@mscho527 mscho527 deleted the boolean_expr_and_bare_except branch December 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscho527 mscho527 mscho527 approved these changes

@lweisburn lweisburn Awaiting requested review from lweisburn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcocdawc @mscho527