Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more ruff warnings #21

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Fix more ruff warnings #21

merged 12 commits into from
Nov 22, 2024

Conversation

mcocdawc
Copy link
Contributor

@mcocdawc mcocdawc commented Nov 21, 2024 •
edited
Loading

  • started to remove unused variables
  • explicitly ignore variables that are in a returned tuple

@mcocdawc mcocdawc force-pushed the fix_more_ruff_warnings branch from f38d6eb to 22712bd Compare November 22, 2024 18:23
@mcocdawc mcocdawc changed the title WIP: Fix more ruff warnings Fix more ruff warnings Nov 22, 2024
mscho527
mscho527 requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mscho527 mscho527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revisit src/kbe/autofrag.py on a later time (but soon enough 😏 )

src/kbe/autofrag.py Show resolved Hide resolved
src/kbe/lo.py Outdated Show resolved Hide resolved
src/kbe/lo.py Outdated Show resolved Hide resolved
src/kbe/lo.py Outdated Show resolved Hide resolved
src/kbe/lo_k.py Outdated Show resolved Hide resolved
src/kbe/lo_k.py Outdated Show resolved Hide resolved
src/kbe/pbe.py Outdated Show resolved Hide resolved
src/kbe/pfrag.py Outdated Show resolved Hide resolved
lweisburn
lweisburn reviewed Nov 22, 2024
View reviewed changes
src/molbe/ube.py Outdated Show resolved Hide resolved
@mscho527 mscho527 mentioned this pull request Nov 22, 2024
Open
mcocdawc and others added 4 commits November 22, 2024 17:20
@mcocdawc
Copy link
Contributor Author

mcocdawc commented Nov 22, 2024 •
edited
Loading

Having these variable names in comments will go out of sync with the code over time.
What do @lweisburn @mscho527 you think about this explicit unused function?
as for example
https://github.com/troyvvgroup/quemb/pull/21/files#diff-611705ac67d6eba400d9a454167fa2e92934e65a125235103ba30fade0e67278R36

mscho527
mscho527 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mscho527 mscho527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool nice cool nice nice

@mcocdawc mcocdawc merged commit e400dce into main Nov 22, 2024
4 checks passed
@mscho527 mscho527 deleted the fix_more_ruff_warnings branch December 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lweisburn lweisburn lweisburn left review comments

@mscho527 mscho527 mscho527 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcocdawc @mscho527 @lweisburn