Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Sync API Refactor #87

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Sync API Refactor #87

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6b9752a
initial new abstraction for sync
helmturner Oct 31, 2023
98a8f81
types: clean up interfaces in iterableTypes.ts
helmturner Nov 14, 2023
f588184
chore: refactor sync api
helmturner Nov 25, 2023
78491c8
types: fix new type signature for TsonType
helmturner Nov 25, 2023
92ffe33
fix: un-break guards and circular reference checks
helmturner Nov 26, 2023
d7c8dbc
tests: fix irrelevant type error in test
helmturner Nov 26, 2023
16944e9
chore: cleanup (#88)
helmturner Nov 26, 2023
8737f51
chore: cleanup
helmturner Nov 26, 2023
ab9df8e
chore: fix typo
helmturner Nov 26, 2023
f97876b
chore: cleanup
helmturner Nov 26, 2023
c9b3e9a
chore: cleanup
helmturner Nov 26, 2023
7c74043
chore: format
helmturner Nov 26, 2023
2f14075
tests: catch missing coverage case, cleanup
helmturner Nov 26, 2023
0d467de
fix: guard shouldn't pass if neither throws nor true
helmturner Nov 26, 2023
23bc039
tests: add test for assert
helmturner Nov 26, 2023
14f2fa6
pff
helmturner Dec 10, 2023
88db45d
chore: right serialization result, wrong indexes
helmturner Jan 3, 2024
f367de1
fix: correct pointer values
helmturner Jan 4, 2024
9aa3dc1
fix: disambiguate serialization output of builtins
helmturner Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { TsonOptions, TsonType, createTson } from "./index.js";
import { expectError, waitError } from "./internals/testUtils.js";

test("multiple handlers for primitive string found", () => {
const stringHandler: TsonType<string, string> = {
const stringHandler = {
primitive: "string",
};
} as TsonType<string, string>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equivalent to the other way around. Did you want to use the satisfies operator?

Copy link
Contributor Author

@helmturner helmturner Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is necessary due to the changes in src/sync/syncTypes.ts (sorry for the slow reply!)

const opts: TsonOptions = {
types: [stringHandler, stringHandler],
};
Expand Down Expand Up @@ -98,9 +98,9 @@ test("async: duplicate keys", async () => {
});

test("async: multiple handlers for primitive string found", async () => {
const stringHandler: TsonType<string, string> = {
const stringHandler = {
primitive: "string",
};
} as TsonType<string, string>;

const err = await waitError(async () => {
const iterator = createTsonAsync({
Expand Down
Loading