Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133901 / 25.10 / Do not allow roles to be set on private endpoints #15664

Merged
merged 5 commits into from
Feb 12, 2025
Merged

NAS-133901 / 25.10 / Do not allow roles to be set on private endpoints #15664

merged 5 commits into from
Feb 12, 2025

Conversation

creatorcary
Copy link
Contributor

@creatorcary creatorcary commented Feb 10, 2025 •
edited
Loading

@creatorcary creatorcary requested review from themylogin and a team February 10, 2025 20:51
@bugclerk bugclerk changed the title Do not allow roles to be set on private endpoints NAS-133901 / 25.10 / Do not allow roles to be set on private endpoints Feb 10, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133901

@anodos325
Copy link
Contributor

Did you verify that there are no external consumers of these API endpoints?

yocalebo
yocalebo requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please 🙂

@creatorcary
Copy link
Contributor Author

Did you verify that there are no external consumers of these API endpoints?

It actually looks like webui is using sharing.smb.share_precheck

@creatorcary creatorcary requested a review from yocalebo February 11, 2025 19:51
@creatorcary creatorcary merged commit bf3dca8 into master Feb 12, 2025
2 checks passed
@creatorcary creatorcary deleted the NAS-133901 branch February 12, 2025 16:28
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themylogin themylogin themylogin approved these changes

@yocalebo yocalebo yocalebo approved these changes

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@creatorcary @bugclerk @anodos325 @themylogin @yocalebo