Simplify virtual store #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simplifies the Store trait by removing the Fs wrapper struct, the Storage types, the static lifetime and the Copy requirement and replaces it with a reference to a DynFilesystem. This gives runners more options on how to implement the store. As the Store trait can now easily be implemented in a safe way, this patch also removes the unsafe keyword from the trait definition.
This patch uses the simplified Store trait to also simplify the store implementation used by the virt module: Instead of using references to static storages and filesystems protected by a mutex, we can now just use separate non-static instances for every test. The only downside is that we can no longer provide raw access to the IFS via the StoreProvider::ifs function, so we cannot run the provisioner app with this platform implementation. But I think this is an acceptable tradeoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the simplified Store trait to also simplify the store
implementation used by the virt module: Instead of using references to
static storages and filesystems protected by a mutex, we can now just
use separate non-static instances for every test.
The only downside is that we can no longer provide raw access to the
IFS via the StoreProvider::ifs function, so we cannot run the
provisioner app with this platform implementation. But I think this is
an acceptable tradeoff.