-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add human readable name of chain state to info message. #138
Conversation
The message "chain state forced to 1 due to prior result found" contains an internal enum index rather than the name of the chain state. Replace with the human readable meaning.
I feel like it would be cleaner to expose and reuse the existing mechanism in libopenarc for doing this translation (see e.g. Line 3666 in eb430db
|
Can you take a look at the updated patch? |
Ah, yeah, that's even better. |
Thanks for this. |
Quick ping on this, any news? |
@flowerysong Would it be possible to merge this one? |
@minfrin Note that the patch should not be merged as-is because it is out of sync with the development branch. The pull request must target the (I have no info on the status of the project though, it seems abandoned.) |
@minfrin This project has been dead for years, unfortunately. I optimistically believed @martinbogo's claim that the project was alive again (#123 (comment)) but that was clearly just an attempt to placate people and not an actual commitment to expend even the slightest effort on it. |
Getting back to this one. Replaced this PR with a new one: #158 |
I'm happy to submit patches, are there people willing to review them? |
The message "chain state forced to 1 due to prior result found"
contains an internal enum index rather than the name of the
chain state. Replace with the human readable meaning.