Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human readable name of chain state to info message. #138

Closed

Conversation

minfrin
Copy link

@minfrin minfrin commented Jan 22, 2021

The message "chain state forced to 1 due to prior result found"
contains an internal enum index rather than the name of the
chain state. Replace with the human readable meaning.

The message "chain state forced to 1 due to prior result found"
contains an internal enum index rather than the name of the
chain state. Replace with the human readable meaning.
@flowerysong
Copy link
Contributor

I feel like it would be cleaner to expose and reuse the existing mechanism in libopenarc for doing this translation (see e.g.

return arc_code_to_name(chainstatus, msg->arc_cstate);
)

@minfrin
Copy link
Author

minfrin commented Jan 24, 2021

Can you take a look at the updated patch?

@flowerysong
Copy link
Contributor

Ah, yeah, that's even better.

@minfrin
Copy link
Author

minfrin commented Feb 4, 2021

Thanks for this.

@minfrin
Copy link
Author

minfrin commented Sep 20, 2021

Quick ping on this, any news?

@minfrin
Copy link
Author

minfrin commented Dec 14, 2021

@flowerysong Would it be possible to merge this one?

@glts
Copy link

glts commented Dec 14, 2021

@minfrin Note that the patch should not be merged as-is because it is out of sync with the development branch.

The pull request must target the develop branch, not master. And then it must be updated in order to compile, eg as done here: https://sources.debian.org/patches/openarc/1.0.0%7Ebeta3+dfsg-1%7Eexp1/chain-state-name.patch/

(I have no info on the status of the project though, it seems abandoned.)

@flowerysong
Copy link
Contributor

@minfrin This project has been dead for years, unfortunately. I optimistically believed @martinbogo's claim that the project was alive again (#123 (comment)) but that was clearly just an attempt to placate people and not an actual commitment to expend even the slightest effort on it.

@minfrin
Copy link
Author

minfrin commented Oct 3, 2022

@minfrin Note that the patch should not be merged as-is because it is out of sync with the development branch.

The pull request must target the develop branch, not master. And then it must be updated in order to compile, eg as done here: https://sources.debian.org/patches/openarc/1.0.0%7Ebeta3+dfsg-1%7Eexp1/chain-state-name.patch/

(I have no info on the status of the project though, it seems abandoned.)

Getting back to this one.

Replaced this PR with a new one: #158

@minfrin minfrin closed this Oct 3, 2022
@minfrin
Copy link
Author

minfrin commented Oct 3, 2022

@minfrin This project has been dead for years, unfortunately. I optimistically believed @martinbogo's claim that the project was alive again (#123 (comment)) but that was clearly just an attempt to placate people and not an actual commitment to expend even the slightest effort on it.

I'm happy to submit patches, are there people willing to review them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants