Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

wip: fixing easy cla #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

andorsk
Copy link
Collaborator

@andorsk andorsk commented May 18, 2023

fix to the easy cla process. wip. working with @henkvancann on this. a couple things pending:

  1. TODO: determine if secrets are set correctly
  2. TODO: need to figure out how to test this without a merge

@andorsk
Copy link
Collaborator Author

andorsk commented May 18, 2023

@henk: we need to see what tokens are set on the repo. Need to check in with Judith on this.

@andorsk
Copy link
Collaborator Author

andorsk commented May 18, 2023

@henk: It's a little hard to test this with a fork. I can't run the workflow directly over actions as part of a forked branch. It might make sense for me to directly make a branch on this repo so I can trigger the action manually. Generally, it's good practice to fork repos, so before I go ahead and make a branch directly on this remote I want to confirm that's ok from your perspective.

@henkvancann
Copy link

@henk: ... It might make sense for me to directly make a branch on this repo so I can trigger the action manually. ...

It's also not my repo. So I can't give you those user rights, I am afraid. Judith is the woman to go to.

@andorsk
Copy link
Collaborator Author

andorsk commented May 18, 2023

@henk I have permissions to do it. But I want to make sure you and others don't have any issues that. I'd guess it'd be fine, but figured I would check beforehand.

@andorsk
Copy link
Collaborator Author

andorsk commented Jun 9, 2023

@JFleenor Can you take a look at this:

Total 5 (delta 1), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
To https://github.com/trustoverip/acdc
 ! [remote rejected] easy-cla-fix -> easy-cla-fix (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/glossary.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/trustoverip/acdc'

I can't really test this flow against the acdc repo without hitting the EasyCLA directly. That means I need access to push to a branch on the repo.

@henkvancann
Copy link

Andor, I've tried to bring in sufficient sense of urgency to do this simple task of giving you access, but I haven't succeeded yet.

@andorsk
Copy link
Collaborator Author

andorsk commented Jun 22, 2023

Hey @henkvancann there's been a thread going on. I still need access, and I've been talking to an LF member to get me it.

To https://github.com/trustoverip/acdc
 ! [remote rejected] easy-cla-fix -> easy-cla-fix (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/glossary.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/trustoverip/acdc'

I'll remind him again and see if I can get access.

@andorsk
Copy link
Collaborator Author

andorsk commented Jun 22, 2023

I have a workaround which I will attempt.

@andorsk
Copy link
Collaborator Author

andorsk commented Jun 22, 2023

@henkvancann can you merge this. I'm still having access issues, so it's probably best we just merge and revert if there's an issue.

@henkvancann
Copy link

henkvancann commented Jul 7, 2023

@henkvancann can you merge this. I'm still having access issues, so it's probably best we just merge and revert if there's an issue.

Hi Andor, I am afraid not, I don't have permission at ToIP. But I have set up a test environment here: https://github.com/WebOfTrust/WOT-terms/actions where I pasted in your PR improvement by hand in glossary.yml,
and I've copied in all the glossary items too: https://github.com/WebOfTrust/WOT-terms/wiki

We have no EasyCLA configured there. So I think that's the reason why the EasyCLA-fix part is skipped in the Actions run on our side.

The Action script in WOT-terms repo of WebofTrust still doesn't finalize correctly (although I see no errors reported during the run).
At least I've got all the necessary permission over there to solve the problem. Maybe you can see where it goes wrong?
The glossary.html doesn't appear in the gh-pages branch of the root of WOT-terms repo.

@henkvancann
Copy link

henkvancann commented Jul 8, 2023

Update 2: https://weboftrust.github.io/WOT-terms/glossary.html is the end-result

Update: we've managed to create and locate the glossary.html file the main branch.

The glossary.html appears in a commit though: https://github.com/WebOfTrust/WOT-terms/tree/d673f5119d41962ea35d705165f15b57a4d304d7 but is not apparent in gh-pages branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants